hide logging member variables, use references for stream op. (#1369)

* hide logging member variables, use references for stream op.

* match parameter naming.

* longer names.

diff --git a/src/core/logging.cc b/src/core/logging.cc
index f6e1a31d64c57da1ec974ee5be0681d7299e4b14..722bc061759f30c143e905b36573073dcc6791c0 100644 (file)
--- a/src/core/logging.cc
+++ b/src/core/logging.cc
@@ -22,9 +22,9 @@
 #include "src/core/logging.h"
 
 
-QDebug operator<< (QDebug debug, const DebugIndent& indent)
+QDebug& operator<< (QDebug& debug, const DebugIndent& indent)
 {
-  for (int i = 1; i<indent.level; i++) {
+  for (int i = 1; i<indent.level_; i++) {
     debug << '.';
   }
   return debug;

diff --git a/src/core/logging.h b/src/core/logging.h
index a417337529facbcae278f3556ce2bfc7fcd81e9b..64f84ea645cd04f6bbac0fd1ed2876ac993e299e 100644 (file)
--- a/src/core/logging.h
+++ b/src/core/logging.h
@@ -52,18 +52,20 @@ public:
 class DebugIndent
 {
 public:
-  explicit DebugIndent(int l) : level(l) {}
+  explicit DebugIndent(int level) : level_(level) {}
+  friend QDebug& operator<<(QDebug& debug, const DebugIndent& indent);
 
-  int level;
+private:
+  int level_;
 };
 
-QDebug operator<< (QDebug debug, const DebugIndent& indent);
+QDebug& operator<< (QDebug& debug, const DebugIndent& indent);
 
 class Debug : public QDebug
 {
 public:
   Debug() : QDebug(QtDebugMsg) {nospace().noquote();}
-  explicit Debug(int l) : QDebug(QtDebugMsg) {nospace().noquote() << DebugIndent(l);}
+  explicit Debug(int level) : QDebug(QtDebugMsg) {nospace().noquote() << DebugIndent(level);}
 };
 
 #endif //  SRC_CORE_LOGGING_H_